-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-6026][VL] Add Support for HiveFileFormat parquet write for Spark 3.4+ #6062
Conversation
Please take a look - @ulysses-you , Thanks!! |
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxBackend.scala
Outdated
Show resolved
Hide resolved
thank you @surnaik , it seems tests did not pass, can you take a look ? |
Run Gluten Clickhouse CI |
This is strange, locally passing, checking the logs, it says nativeUsed was false, investigating further |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Found the issue, have raised the fix, waiting for CI to pass. |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm if tests pass, thank you
…into srnk/hivefileformatwrite
Run Gluten Clickhouse CI |
@ulysses-you could you please take a look once again, all the tests are now passing. Thanks for your time! |
@PHILO-HE could you please take a look as well. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice! Thanks!
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
What changes were proposed in this pull request?
Adds support of HiveFileFormat write when output file type is of type parquet
(Fixes: #6026 )
How was this patch tested?
Fixed the existing UTs to check whether pushed to Velox.
Checked manually in Spark.