-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL] Fix inaccurate calculation of task slot number used by s.g.s.c.b.v.IOThreads #6071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhztheplayer
changed the title
[VL] Fix wrong calculation of task slot number used by s.g.s.c.b.v.IOThreads
[VL] Fix inaccurate calculation of task slot number used by s.g.s.c.b.v.IOThreads
Jun 13, 2024
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
JkSelf
previously approved these changes
Jun 13, 2024
Run Gluten Clickhouse CI |
JkSelf
approved these changes
Jun 14, 2024
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COLUMNAR_VELOX_CONNECTOR_IO_THREADS.defaultValueString
is not accurate enough when it's used in backend initialization because:local[N]
mode is not countedThe patch fixes the issue.