Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Remove getPartitionFilters from scanTransformer #6076

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

gaoyangxiaozhu
Copy link
Contributor

What changes were proposed in this pull request?

getPartitionFilters API not use any more

(Fixes: #ISSUE-ID)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

@gaoyangxiaozhu
Copy link
Contributor Author

@zhouyuan / @yma11 / @PHILO-HE small change, please help review

Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PHILO-HE PHILO-HE merged commit d18ab8f into apache:main Jun 14, 2024
40 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_6076_time.csv log/native_master_06_13_2024_142cf0fbc_time.csv difference percentage
q1 33.72 35.57 1.843 105.47%
q2 23.91 23.78 -0.132 99.45%
q3 37.01 39.61 2.593 107.00%
q4 33.18 32.76 -0.415 98.75%
q5 69.74 67.54 -2.200 96.85%
q6 7.95 9.42 1.468 118.47%
q7 80.30 80.69 0.391 100.49%
q8 83.17 84.77 1.598 101.92%
q9 124.56 120.70 -3.860 96.90%
q10 47.96 45.25 -2.704 94.36%
q11 20.43 19.79 -0.639 96.87%
q12 26.07 27.92 1.844 107.07%
q13 39.90 39.43 -0.466 98.83%
q14 18.72 18.98 0.262 101.40%
q15 31.65 33.04 1.398 104.42%
q16 14.66 13.85 -0.811 94.47%
q17 101.46 101.57 0.104 100.10%
q18 148.25 144.97 -3.284 97.79%
q19 16.82 13.79 -3.026 82.00%
q20 28.01 26.68 -1.329 95.26%
q21 258.91 260.83 1.921 100.74%
q22 12.19 13.91 1.725 114.16%
total 1258.57 1254.85 -3.718 99.70%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants