Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE] Support JDK 11 #6112

Merged
merged 11 commits into from
Jun 20, 2024
Merged

[CORE] Support JDK 11 #6112

merged 11 commits into from
Jun 20, 2024

Conversation

surnaik
Copy link
Contributor

@surnaik surnaik commented Jun 17, 2024

What changes were proposed in this pull request?

  • Add jdk-11 maven profile
  • Add jdk11 tpcds/tpch github action workflow
  • Update docs
  • Upgrades Caffeine cache version for Java 11 and 17

How was this patch tested?

Pass CI

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

@surnaik
Copy link
Contributor Author

surnaik commented Jun 17, 2024

@ulysses-you Requesting your review since you upgraded to Java 17. Thanks!

@surnaik
Copy link
Contributor Author

surnaik commented Jun 18, 2024

Please take a look - @zhouyuan @yaooqinn Thanks!!

Copy link
Contributor

@zhouyuan zhouyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, is it ok to limit the tests to Spark 3.5 first, so we could save some CI resource?

@ulysses-you
Copy link
Contributor

+1 for @zhouyuan to reduce the CI resource

Copy link

Run Gluten Clickhouse CI

1 similar comment
Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

1 similar comment
Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

@surnaik
Copy link
Contributor Author

surnaik commented Jun 19, 2024

@zhouyuan @ulysses-you I have now enabled it only for Spark 3.5, Please take a look at this again. Thanks!

Copy link
Contributor

@zhouyuan zhouyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ulysses-you ulysses-you merged commit bfd089e into apache:main Jun 20, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants