-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert SortShuffleManager changes in ColumnarShuffleManager #6149
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
Run Gluten Clickhouse CI |
@zhli1142015 @marin-ma @ulysses-you can you please review this PR? Will working on investigating the regression separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's interesting.. I'm fine to revert it first
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
Thanks! I am also puzzled, will keep you updated on any findings. |
PR6022 caused performance regression in our nightly test. |
What changes were proposed in this pull request?
Revert ColumnarShuffleManager changes in #6022 to mitigate issue #6140