-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL][Core] Turn off InputFileNameReplaceRule with feature flag by default #6161
[VL][Core] Turn off InputFileNameReplaceRule with feature flag by default #6161
Conversation
@zhztheplayer / @FelixYBW / @jinchengchenghh FYI, let's turn off this rule in default per suggestion of Hongze in the PR #6139 |
Run Gluten Clickhouse CI |
@PHILO-HE don't think the CH fail related to my change, and @jinchengchenghh / @zhztheplayer if it is ok please let review and let's merge the PR asap in case any fallback issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait for CI. Thanks.
Run Gluten Clickhouse CI |
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
What changes were proposed in this pull request?
Let's turn off this rule firstly in case any failure with scan fallback and project has
input_file_name
.(Fixes: #ISSUE-ID)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)