Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL][Core] Turn off InputFileNameReplaceRule with feature flag by default #6161

Conversation

gaoyangxiaozhu
Copy link
Contributor

What changes were proposed in this pull request?

Let's turn off this rule firstly in case any failure with scan fallback and project has input_file_name.

(Fixes: #ISSUE-ID)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@gaoyangxiaozhu
Copy link
Contributor Author

gaoyangxiaozhu commented Jun 20, 2024

@zhztheplayer / @FelixYBW / @jinchengchenghh FYI, let's turn off this rule in default per suggestion of Hongze in the PR #6139

Copy link

Run Gluten Clickhouse CI

@gaoyangxiaozhu gaoyangxiaozhu changed the title [VL][Core ] Turn off InputFileNameReplaceRule with feature flag in default [VL][Core] Turn off InputFileNameReplaceRule with feature flag in default Jun 20, 2024
@apache apache deleted a comment from github-actions bot Jun 20, 2024
@gaoyangxiaozhu
Copy link
Contributor Author

@PHILO-HE don't think the CH fail related to my change, and @jinchengchenghh / @zhztheplayer if it is ok please let review and let's merge the PR asap in case any fallback issue

Copy link
Member

@zhztheplayer zhztheplayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for CI. Thanks.

@lwz9103
Copy link
Contributor

lwz9103 commented Jun 20, 2024

Run Gluten Clickhouse CI

@PHILO-HE PHILO-HE changed the title [VL][Core] Turn off InputFileNameReplaceRule with feature flag in default [VL][Core] Turn off InputFileNameReplaceRule with feature flag by default Jun 20, 2024
@zhztheplayer zhztheplayer merged commit 35695d1 into apache:main Jun 20, 2024
42 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_6161_time.csv log/native_master_06_19_2024_27c32f1b15_time.csv difference percentage
q1 37.68 34.61 -3.062 91.87%
q2 23.72 25.46 1.744 107.35%
q3 42.34 38.59 -3.749 91.15%
q4 31.95 33.98 2.034 106.37%
q5 68.59 70.97 2.383 103.47%
q6 6.48 6.54 0.066 101.03%
q7 80.76 85.08 4.322 105.35%
q8 86.10 87.11 1.017 101.18%
q9 120.50 123.67 3.175 102.63%
q10 48.40 44.85 -3.552 92.66%
q11 20.77 20.56 -0.207 99.00%
q12 28.39 27.28 -1.103 96.12%
q13 38.02 39.58 1.555 104.09%
q14 20.58 18.81 -1.764 91.43%
q15 29.60 33.35 3.748 112.66%
q16 13.98 14.28 0.301 102.15%
q17 103.59 105.60 2.009 101.94%
q18 146.98 144.60 -2.375 98.38%
q19 14.76 13.77 -0.991 93.29%
q20 29.89 29.04 -0.851 97.15%
q21 261.87 265.23 3.351 101.28%
q22 12.36 12.88 0.516 104.18%
total 1267.29 1275.86 8.567 100.68%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants