Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Enable ShuffleSuite with ColumnarShuffleManager #6179

Closed
wants to merge 2 commits into from

Conversation

acvictor
Copy link
Contributor

@acvictor acvictor commented Jun 21, 2024

What changes were proposed in this pull request?

Enable ShuffleSuite against ColumnarShuffleManager.

How was this patch tested?

Enabled a new suite.

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

@acvictor acvictor changed the title [VL] Enabled ShuffleSuite with ColumnarShuffleManager [VL] Enable ShuffleSuite with ColumnarShuffleManager Jun 21, 2024
Copy link

Run Gluten Clickhouse CI

@acvictor acvictor marked this pull request as ready for review June 22, 2024 04:58
@acvictor
Copy link
Contributor Author

@marin-ma can you please review?

@marin-ma
Copy link
Contributor

Seems like we don't need to enable this suite. ShuffleSuite is an abstract class in spark, and we have enabled SortShuffleSuite to run all test cases.

@acvictor acvictor closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants