Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] Test simd hash #6216

Closed
wants to merge 3 commits into from
Closed

Conversation

zhli1142015
Copy link
Contributor

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

(Fixes: #ISSUE-ID)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@zhli1142015
Copy link
Contributor Author

/Benchmark Velox TPCH

@zhli1142015
Copy link
Contributor Author

/Benchmark Velox TPCDS

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====

query log/native_6216_time.csv log/native_master_06_24_2024_f07e348f4d_time.csv difference percentage
q1 14.71 19.21 4.505 130.63%
q2 17.26 14.16 -3.101 82.03%
q3 2.30 3.95 1.648 171.72%
q4 63.22 62.97 -0.253 99.60%
q5 6.71 7.87 1.155 117.21%
q6 3.57 2.50 -1.063 70.18%
q7 5.79 5.49 -0.306 94.72%
q8 5.27 5.08 -0.186 96.48%
q9 19.53 22.45 2.920 114.95%
q10 12.01 11.33 -0.684 94.31%
q11 39.90 35.20 -4.702 88.22%
q12 1.37 1.47 0.098 107.10%
q13 6.02 5.37 -0.647 89.25%
q14a 42.67 43.48 0.807 101.89%
q14b 42.66 41.98 -0.678 98.41%
q15 2.65 2.63 -0.020 99.24%
q16 39.82 38.68 -1.137 97.14%
q17 4.92 7.38 2.469 150.22%
q18 6.12 6.61 0.481 107.86%
q19 3.46 2.22 -1.238 64.20%
q20 1.42 2.59 1.175 182.83%
q21 4.18 1.18 -3.006 28.18%
q22 8.63 9.87 1.233 114.28%
q23a 84.98 83.09 -1.895 97.77%
q23b 102.65 100.62 -2.028 98.02%
q24a 72.18 73.78 1.604 102.22%
q24b 76.78 67.56 -9.222 87.99%
q25 4.38 5.96 1.582 136.17%
q26 2.87 2.94 0.069 102.41%
q27 3.51 3.16 -0.345 90.17%
q28 21.04 24.23 3.192 115.17%
q29 10.53 6.98 -3.548 66.29%
q30 7.75 4.33 -3.416 55.90%
q31 6.15 7.92 1.777 128.92%
q32 1.18 1.03 -0.151 87.17%
q33 6.33 4.87 -1.457 76.99%
q34 5.31 3.83 -1.481 72.14%
q35 7.80 7.86 0.056 100.72%
q36 3.62 3.44 -0.178 95.10%
q37 5.86 4.10 -1.765 69.90%
q38 12.00 11.63 -0.368 96.93%
q39a 6.01 3.22 -2.781 53.69%
q39b 3.19 5.12 1.924 160.22%
q40 3.72 3.92 0.194 105.21%
q41 0.64 0.60 -0.049 92.43%
q42 0.96 0.89 -0.072 92.55%
q43 3.51 3.73 0.223 106.35%
q44 8.56 8.56 0.005 100.06%
q45 3.49 3.60 0.104 102.98%
q46 3.49 3.37 -0.122 96.50%
q47 14.01 14.18 0.172 101.23%
q48 4.36 4.58 0.219 105.03%
q49 9.60 10.03 0.427 104.45%
q50 24.45 23.93 -0.517 97.89%
q51 8.60 8.64 0.046 100.54%
q52 1.05 1.05 -0.008 99.25%
q53 1.97 2.03 0.066 103.33%
q54 3.35 3.21 -0.137 95.91%
q55 1.06 0.95 -0.102 90.39%
q56 4.36 4.37 0.012 100.27%
q57 8.69 8.62 -0.069 99.21%
q58 2.43 2.70 0.264 110.87%
q59 14.67 13.99 -0.686 95.33%
q60 4.75 6.49 1.747 136.80%
q61 5.53 5.53 -0.000 100.00%
q62 4.33 4.80 0.464 110.71%
q63 2.14 2.28 0.140 106.52%
q64 49.17 49.93 0.757 101.54%
q65 13.64 13.70 0.060 100.44%
q66 3.32 3.36 0.040 101.22%
q67 346.86 350.98 4.127 101.19%
q68 3.66 3.69 0.034 100.92%
q69 6.59 6.13 -0.460 93.02%
q70 12.03 11.04 -0.995 91.73%
q71 3.37 3.07 -0.303 91.01%
q72 187.84 191.38 3.542 101.89%
q73 6.23 2.72 -3.511 43.67%
q74 21.27 21.09 -0.178 99.16%
q75 23.16 23.11 -0.055 99.76%
q76 9.95 9.27 -0.682 93.15%
q77 2.16 2.07 -0.092 95.75%
q78 41.68 43.31 1.627 103.90%
q79 3.48 3.43 -0.052 98.52%
q80 11.41 11.26 -0.150 98.69%
q81 5.20 5.05 -0.155 97.02%
q82 8.89 9.66 0.764 108.59%
q83 1.63 1.61 -0.015 99.08%
q84 2.73 2.67 -0.061 97.75%
q85 6.86 6.70 -0.163 97.63%
q86 3.23 3.29 0.061 101.90%
q87 13.50 12.25 -1.251 90.73%
q88 23.53 24.67 1.142 104.85%
q89 3.16 3.17 0.013 100.40%
q90 10.52 10.11 -0.413 96.07%
q91 2.70 2.68 -0.027 98.99%
q92 1.34 1.30 -0.041 96.92%
q93 28.40 28.82 0.421 101.48%
q94 20.74 21.20 0.452 102.18%
q9 83.64 84.22 0.578 100.69%
q5 3.45 3.49 0.039 101.13%
q96 12.06 12.33 0.271 102.25%
q97 2.13 1.94 -0.194 90.92%
q98 8.34 9.42 1.089 113.07%
q99 8.34 9.42 1.089 113.07%
total 1925.93 1915.52 -10.419 99.46%

@zhouyuan
Copy link
Contributor

CC @PHILO-HE

@zhli1142015 zhli1142015 changed the title Test simd re2 [DNM] Test simd re2 Jun 25, 2024
@zhli1142015
Copy link
Contributor Author

zhli1142015 commented Jun 25, 2024

CC @PHILO-HE

This is just a test PR to verify my velox changes, facebookincubator/velox#10301 and facebookincubator/velox#10273.
You don't need to look at this, or do you see any issue related to this?

@zhouyuan
Copy link
Contributor

CC @PHILO-HE

This is just a test PR to verify my velox changes, facebookincubator/velox#10301 and facebookincubator/velox#10273. You don't need to look at this, or do you see any issue related to this?

@zhli1142015 Yes we do see an optimized lib better than re2 for regex workload, @PHILO-HE is looking on this part

@zhli1142015 zhli1142015 changed the title [DNM] Test simd re2 [DNM] Test simd2 Jun 27, 2024
@zhli1142015 zhli1142015 changed the title [DNM] Test simd2 [DNM] Test simd hash Jun 27, 2024
@zhli1142015
Copy link
Contributor Author

/Benchmark Velox TPCH

@zhli1142015
Copy link
Contributor Author

/Benchmark Velox TPCDS

@zhli1142015
Copy link
Contributor Author

/Benchmark Velox TPCDS

@zhli1142015
Copy link
Contributor Author

/Benchmark Velox TPCH

1 similar comment
@zhli1142015
Copy link
Contributor Author

/Benchmark Velox TPCH

@zhli1142015
Copy link
Contributor Author

/Benchmark Velox TPCDS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants