-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL] Support building arrow CPP and finding installed arrow libs from system #6229
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
90d1b44
to
8483413
Compare
05a13cb
to
a80046f
Compare
Please also update the document, thanks! |
@jinchengchenghh, I will do that. Thanks! |
And we don't need to add arrow patch here https://github.com/apache/incubator-gluten/blob/main/ep/build-velox/src/get_velox.sh#L249 |
@jinchengchenghh, you mean we don't need this patch here or don't need to use git to add it? The git add may be still useful for checking ep cache I guess. |
What changes were proposed in this pull request?
This is a part of work to let Gluten/Velox use installed arrow libraries instead of always
building from source, which is for simplifying Gluten/Velox build and saving CI time.
We also have a velox PR to let velox find and use the installed arrow libraries: facebookincubator/velox#9992.
How was this patch tested?
CI.