Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Support building arrow CPP and finding installed arrow libs from system #6229

Merged
merged 8 commits into from
Jun 28, 2024

Conversation

PHILO-HE
Copy link
Contributor

What changes were proposed in this pull request?

This is a part of work to let Gluten/Velox use installed arrow libraries instead of always
building from source, which is for simplifying Gluten/Velox build and saving CI time.

We also have a velox PR to let velox find and use the installed arrow libraries: facebookincubator/velox#9992.

How was this patch tested?

CI.

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@PHILO-HE PHILO-HE changed the title Support building arrow CPP and using installed arrow libraries [VL] Support building arrow CPP and using installed arrow libraries Jun 26, 2024
@PHILO-HE PHILO-HE force-pushed the reuse-arrow branch 4 times, most recently from 90d1b44 to 8483413 Compare June 26, 2024 07:22
@PHILO-HE PHILO-HE force-pushed the reuse-arrow branch 3 times, most recently from 05a13cb to a80046f Compare June 27, 2024 07:36
@PHILO-HE PHILO-HE changed the title [VL] Support building arrow CPP and using installed arrow libraries [VL] Support building arrow CPP and finding installed arrow libs from system Jun 28, 2024
@PHILO-HE PHILO-HE merged commit 1b8be1d into apache:main Jun 28, 2024
41 checks passed
@jinchengchenghh
Copy link
Contributor

Please also update the document, thanks!

@PHILO-HE
Copy link
Contributor Author

PHILO-HE commented Jul 5, 2024

Please also update the document, thanks!

@jinchengchenghh, I will do that. Thanks!

@jinchengchenghh
Copy link
Contributor

@PHILO-HE
Copy link
Contributor Author

PHILO-HE commented Jul 5, 2024

And we don't need to add arrow patch here https://github.com/apache/incubator-gluten/blob/main/ep/build-velox/src/get_velox.sh#L249

@jinchengchenghh, you mean we don't need this patch here or don't need to use git to add it? The git add may be still useful for checking ep cache I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants