[CELEBORN] Add config to control celeborn fallback for CI #6230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI |
kerwin-zk
force-pushed
the
fallback_config
branch
from
0eb852e to
7f2372a
Compare
|
Run Gluten Clickhouse CI |
|
@PHILO-HE cc |
PHILO-HE
reviewed
Jun 26, 2024
| val CELEBORN_FALLBACK_ENABLED = | ||
| buildStaticConf("spark.gluten.sql.columnar.shuffle.celeborn.fallback.enabled") | ||
| .internal() | ||
| .doc("Enable celeborn fallback. Throw an exception immediately" + |
There was a problem hiding this comment.
Suggestion:
If enabled, fall back to ColumnarShuffleManager when celeborn service is unavailable. Otherwise, throw an exception.
kerwin-zk
force-pushed
the
fallback_config
branch
from
7f2372a to
a4b32ea
Compare
kerwin-zk
force-pushed
the
fallback_config
branch
from
a4b32ea to
077b235
Compare
|
Run Gluten Clickhouse CI |
1 similar comment
|
Run Gluten Clickhouse CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add config to control celeborn fallback for CI
How was this patch tested?
CI