Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-2790][CH] Fix diff between ch char and spark chr #6236

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

taiyang-li
Copy link
Contributor

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

(Fixes: #2790)

Copy link

#2790

Copy link

Run Gluten Clickhouse CI

1 similar comment
Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

@taiyang-li taiyang-li requested review from zzcclp and exmy June 27, 2024 07:09
exmy
exmy previously approved these changes Jun 27, 2024
Copy link

Run Gluten Clickhouse CI

Copy link
Contributor

@zzcclp zzcclp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzcclp zzcclp merged commit 22dc4fd into apache:main Jun 27, 2024
42 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====

query log/native_master_06_27_2024_time.csv log/native_master_06_26_2024_0800596b5_time.csv difference percentage
q1 14.69 14.62 -0.075 99.49%
q2 19.29 17.50 -1.789 90.72%
q3 4.34 4.47 0.126 102.90%
q4 63.59 64.49 0.899 101.41%
q5 6.46 7.81 1.350 120.89%
q6 3.58 4.14 0.555 115.49%
q7 4.12 4.22 0.095 102.30%
q8 5.08 5.63 0.549 110.81%
q9 18.54 18.75 0.206 101.11%
q10 11.30 10.87 -0.437 96.13%
q11 36.94 40.96 4.016 110.87%
q12 2.41 1.58 -0.829 65.66%
q13 5.68 5.39 -0.286 94.97%
q14a 41.94 42.12 0.179 100.43%
q14b 44.07 42.17 -1.900 95.69%
q15 2.84 2.73 -0.113 96.03%
q16 39.50 38.62 -0.879 97.77%
q17 4.81 4.78 -0.032 99.33%
q18 6.24 6.43 0.189 103.02%
q19 2.39 3.14 0.744 131.07%
q20 1.42 1.65 0.231 116.23%
q21 5.68 2.69 -2.981 47.48%
q22 8.70 10.67 1.976 122.72%
q23a 87.00 84.61 -2.396 97.25%
q23b 102.16 103.24 1.080 101.06%
q24a 75.38 74.63 -0.749 99.01%
q24b 76.71 72.65 -4.057 94.71%
q25 5.95 4.74 -1.215 79.60%
q26 2.97 2.91 -0.057 98.09%
q27 3.30 9.17 5.868 277.90%
q28 23.56 22.92 -0.634 97.31%
q29 7.70 8.25 0.553 107.17%
q30 6.47 4.33 -2.137 66.97%
q31 6.23 6.31 0.074 101.19%
q32 1.10 1.22 0.124 111.28%
q33 4.84 4.83 -0.007 99.86%
q34 3.54 3.58 0.035 100.97%
q35 6.47 6.46 -0.008 99.87%
q36 3.30 3.29 -0.008 99.76%
q37 3.95 4.05 0.098 102.49%
q38 11.86 11.79 -0.070 99.41%
q39a 3.42 3.55 0.125 103.65%
q39b 2.87 2.87 -0.005 99.82%
q40 3.75 6.01 2.265 160.45%
q41 0.62 0.62 0.004 100.60%
q42 0.92 0.94 0.022 102.36%
q43 3.52 3.86 0.332 109.43%
q44 8.25 8.95 0.699 108.47%
q45 3.67 3.62 -0.046 98.76%
q46 3.31 4.60 1.291 139.05%
q47 14.71 14.25 -0.453 96.92%
q48 4.57 4.58 0.005 100.12%
q49 9.74 9.49 -0.242 97.51%
q50 23.70 22.38 -1.313 94.46%
q51 8.40 8.78 0.382 104.54%
q52 1.08 1.03 -0.052 95.21%
q53 2.03 2.01 -0.018 99.13%
q54 3.45 3.22 -0.230 93.34%
q55 1.02 0.96 -0.059 94.19%
q56 4.46 4.47 0.010 100.23%
q57 8.48 8.60 0.128 101.51%
q58 2.69 2.56 -0.126 95.33%
q59 13.96 14.06 0.099 100.71%
q60 6.49 8.08 1.591 124.53%
q61 5.72 5.76 0.032 100.56%
q62 4.55 4.44 -0.115 97.48%
q63 2.33 2.35 0.019 100.81%
q64 49.04 49.07 0.037 100.08%
q65 13.81 15.30 1.487 110.77%
q66 5.59 3.54 -2.057 63.23%
q67 349.42 348.90 -0.528 99.85%
q68 3.45 3.80 0.350 110.13%
q69 6.40 6.58 0.183 102.85%
q70 13.50 13.30 -0.205 98.48%
q71 2.02 2.37 0.354 117.53%
q72 187.82 191.80 3.980 102.12%
q73 4.45 2.70 -1.754 60.62%
q74 22.19 21.14 -1.050 95.27%
q75 23.03 23.11 0.084 100.37%
q76 9.14 9.17 0.030 100.33%
q77 2.19 2.27 0.079 103.61%
q78 41.33 41.17 -0.166 99.60%
q79 3.57 3.48 -0.095 97.33%
q80 11.02 10.95 -0.064 99.42%
q81 5.29 4.85 -0.436 91.75%
q82 9.55 9.66 0.113 101.18%
q83 1.60 1.77 0.167 110.44%
q84 2.78 2.66 -0.115 95.88%
q85 7.01 6.68 -0.331 95.28%
q86 3.21 3.35 0.141 104.39%
q87 12.23 12.18 -0.050 99.59%
q88 27.33 24.96 -2.371 91.33%
q89 3.36 3.27 -0.089 97.34%
q90 10.11 8.00 -2.104 79.18%
q91 2.62 2.58 -0.031 98.81%
q92 1.35 1.31 -0.046 96.58%
q93 28.71 29.00 0.285 100.99%
q94 21.28 21.28 -0.004 99.98%
q9 85.02 83.19 -1.831 97.85%
q5 3.53 3.78 0.248 107.01%
q96 12.38 12.45 0.077 100.62%
q97 2.16 2.01 -0.149 93.12%
q98 8.93 9.96 1.031 111.54%
q99 8.93 9.96 1.031 111.54%
total 1930.27 1928.06 -2.202 99.89%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CH] spark chr and CH char need to be aligned
4 participants