[GLUTEN-6159][CH] Support array functions with lambda functions #6248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI |
lgbo-ustc
force-pushed
the
lambda_function
branch
from
49d2f58 to
d8ea7ee
Compare
|
Run Gluten Clickhouse CI |
taiyang-li
reviewed
Jun 27, 2024
| namespace local_engine | ||
| { | ||
| /// Refer to `PlannerActionsVisitorImpl::visitLambda` for how to build a lambda function node. | ||
| class LambdaFunction : public FunctionParser |
There was a problem hiding this comment.
lambdaFunction.cpp is better.
lgbo-ustc
force-pushed
the
lambda_function
branch
from
d8ea7ee to
86955e5
Compare
|
Run Gluten Clickhouse CI |
lgbo-ustc
force-pushed
the
lambda_function
branch
from
86955e5 to
05d74df
Compare
|
Run Gluten Clickhouse CI |
lgbo-ustc
force-pushed
the
lambda_function
branch
from
05d74df to
b49fa22
Compare
|
Run Gluten Clickhouse CI |
lgbo-ustc
force-pushed
the
lambda_function
branch
from
b49fa22 to
d16d30e
Compare
|
Run Gluten Clickhouse CI |
lgbo-ustc
force-pushed
the
lambda_function
branch
from
d16d30e to
44dfb08
Compare
|
Run Gluten Clickhouse CI |
lgbo-ustc
force-pushed
the
lambda_function
branch
from
44dfb08 to
1e20b5a
Compare
|
Run Gluten Clickhouse CI |
lgbo-ustc
force-pushed
the
lambda_function
branch
from
1e20b5a to
3b61b87
Compare
|
Run Gluten Clickhouse CI |
lgbo-ustc
force-pushed
the
lambda_function
branch
from
3b61b87 to
719cd31
Compare
|
Run Gluten Clickhouse CI |
1 similar comment
|
Run Gluten Clickhouse CI |
lgbo-ustc
force-pushed
the
lambda_function
branch
from
9368f99 to
ef973e0
Compare
|
Run Gluten Clickhouse CI |
lgbo-ustc
force-pushed
the
lambda_function
branch
from
ef973e0 to
4041339
Compare
|
Run Gluten Clickhouse CI |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
Fixes: #6159
support following array functions
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
unit tests
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)