Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UT] Remove isVeloxBackendLoaded usage from file metadata UT #6249

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

gaoyangxiaozhu
Copy link
Contributor

What changes were proposed in this pull request?

As we claim the isxxBackendLoaded usage should be better avoid, and will be remove when time ripe.
I didn't notice that when adding this part ut before.

(Fixes: #ISSUE-ID)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@gaoyangxiaozhu
Copy link
Contributor Author

gaoyangxiaozhu commented Jun 27, 2024

@PHILO-HE / @rui-mo / @yma11 help review

Copy link

Run Gluten Clickhouse CI

@gaoyangxiaozhu
Copy link
Contributor Author

@PHILO-HE the CH fail could you help re-trigger only CH run ?

@PHILO-HE
Copy link
Contributor

Run Gluten Clickhouse CI

@PHILO-HE
Copy link
Contributor

@PHILO-HE the CH fail could you help re-trigger only CH run ?

@gaoyangxiaozhu, just triggered. We can leave a comment "Run Gluten Clickhouse CI" to trigger CH CI.

@PHILO-HE PHILO-HE changed the title [UT] Remove isVeloxBackendLoaded usage of file metadata ut [UT] Remove isVeloxBackendLoaded usage from file metadata UT Jun 27, 2024
Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

Run Gluten Clickhouse CI

@gaoyangxiaozhu
Copy link
Contributor Author

@PHILO-HE could you help merge ?

@PHILO-HE PHILO-HE merged commit f837f06 into apache:main Jun 27, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants