-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CH] Support bit_length/octet_length function #6259
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
@@ -438,6 +438,9 @@ class ClickHouseTestSettings extends BackendTestSettings { | |||
.exclude("string overlay function") | |||
.exclude("binary overlay function") | |||
.exclude("string parse_url function") | |||
.exclude("string / binary length function") | |||
.exclude("SPARK-36751: add octet length api for scala") | |||
.exclude("SPARK-36751: add bit length api for scala") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exlcude these three uts due to diff for cast(2.0f to string)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What changes were proposed in this pull request?
support
bit_length/octet_length
functionmove
length
impl tofunciton parser
These three functions may receive
int
type argument in spark ut, add acast to string
.How was this patch tested?
PASS CI