Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL][UNIFFLE] Remove inc BytesWritten in VeloxUniffleColumnarShuffleWriter #6270

Closed
wants to merge 1 commit into from

Conversation

wForget
Copy link
Member

@wForget wForget commented Jun 28, 2024

What changes were proposed in this pull request?

Remove inc BytesWritten in VeloxUniffleColumnarShuffleWriter

Fixes: #6269

How was this patch tested?

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale stale label Aug 13, 2024
@wForget
Copy link
Member Author

wForget commented Aug 13, 2024

cc @summaryzb @PHILO-HE Could you please take a look?

Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pr! I have no comment. @summaryzb, please confirm the change.

@github-actions github-actions bot removed the stale stale label Aug 14, 2024
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale stale label Sep 28, 2024
Copy link

github-actions bot commented Oct 8, 2024

This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks.

@github-actions github-actions bot closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BytesWritten is double counted in uniffle shuffle writer
2 participants