Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Spark mask function support #6271

Merged
merged 13 commits into from
Jul 30, 2024

Conversation

gaoyangxiaozhu
Copy link
Contributor

@gaoyangxiaozhu gaoyangxiaozhu commented Jun 28, 2024

What changes were proposed in this pull request?

Spark mask function only available for 3.4+.

(Fixes: #ISSUE-ID)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Jul 1, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Jul 1, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Jul 1, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Jul 1, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Jul 1, 2024

Run Gluten Clickhouse CI

@gaoyangxiaozhu
Copy link
Contributor Author

@PHILO-HE / @zhouyuan looks CI fail during maven and java setup stage, please help fix.
image

Looks all recent active PRs fail due to this reason.

Copy link

github-actions bot commented Jul 2, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Jul 2, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Jul 2, 2024

Run Gluten Clickhouse CI

1 similar comment
@gaoyangxiaozhu
Copy link
Contributor Author

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

@gaoyangxiaozhu gaoyangxiaozhu changed the title [VL][WIP] Spark mask function support [VL] Spark mask function support Jul 30, 2024
@gaoyangxiaozhu
Copy link
Contributor Author

@PHILO-HE / @rui-mo could you help review ?

Copy link
Contributor

@rui-mo rui-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@gaoyangxiaozhu gaoyangxiaozhu requested a review from PHILO-HE July 30, 2024 07:21
@gaoyangxiaozhu
Copy link
Contributor Author

please help merge guys, if you both ok for this part. thank you @rui-mo / @PHILO-HE

@PHILO-HE PHILO-HE merged commit 295899c into apache:main Jul 30, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants