Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] ADD NOTICE #6277

Merged
merged 2 commits into from
Jul 3, 2024
Merged

[MINOR] ADD NOTICE #6277

merged 2 commits into from
Jul 3, 2024

Conversation

caicancai
Copy link
Member

@caicancai caicancai commented Jun 29, 2024

What changes were proposed in this pull request?

Add NOTICE

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@Yohahaha
Copy link
Contributor

Yohahaha commented Jul 1, 2024

cc @weiting-chen @yaooqinn

@FelixYBW FelixYBW requested a review from weiting-chen July 1, 2024 18:07
Some apache projects are mentioned in the license also require to be added into the NOTICE file
Copy link
Contributor

@weiting-chen weiting-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the update NOTICE with more Apache project added

@caicancai
Copy link
Member Author

Check the update NOTICE with more Apache project added

Thanks for the reminder, I will check it later.

@weiting-chen weiting-chen merged commit 2dde39c into apache:main Jul 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants