[CELEBORN] Fix Celeborn support of get-started document #6282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Ping @kerwin-zk, @taiyang-li, @liuneng1994, @summaryzb. |
taiyang-li
reviewed
Jul 1, 2024
taiyang-li
reviewed
Jul 1, 2024
|
@zzcclp can you also review it ? |
|
@taiyang-li, I have addressed above comments. PTAL. cc @zzcclp. |
kerwin-zk
approved these changes
Jul 1, 2024
kerwin-zk
pushed a commit
to apache/celeborn
that referenced
this pull request
Jul 1, 2024
### What changes were proposed in this pull request? Introduce `ClickHouse Backend` in `Gluten Support` document. Meanwhile, fix the profile via `-Pceleborn` to compile gluten module. ### Why are the changes needed? Gluten with ClickHouse backend supports Celeborn as remote shuffle service at present. Gluten Support document should introduce ClickHouse Backend to guide user usage of Gluten with ClickHouse backend. Backport apache/incubator-gluten#6282. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No. Closes #2594 from SteNicholas/CELEBORN-1486. Authored-by: SteNicholas <[email protected]> Signed-off-by: xiyu.zk <[email protected]>
kerwin-zk
pushed a commit
to apache/celeborn
that referenced
this pull request
Jul 1, 2024
### What changes were proposed in this pull request? Introduce `ClickHouse Backend` in `Gluten Support` document. Meanwhile, fix the profile via `-Pceleborn` to compile gluten module. ### Why are the changes needed? Gluten with ClickHouse backend supports Celeborn as remote shuffle service at present. Gluten Support document should introduce ClickHouse Backend to guide user usage of Gluten with ClickHouse backend. Backport apache/incubator-gluten#6282. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No. Closes #2594 from SteNicholas/CELEBORN-1486. Authored-by: SteNicholas <[email protected]> Signed-off-by: xiyu.zk <[email protected]> (cherry picked from commit 5a39fc7) Signed-off-by: xiyu.zk <[email protected]>
kerwin-zk
pushed a commit
to apache/celeborn
that referenced
this pull request
Jul 1, 2024
### What changes were proposed in this pull request? Introduce `ClickHouse Backend` in `Gluten Support` document. Meanwhile, fix the profile via `-Pceleborn` to compile gluten module. ### Why are the changes needed? Gluten with ClickHouse backend supports Celeborn as remote shuffle service at present. Gluten Support document should introduce ClickHouse Backend to guide user usage of Gluten with ClickHouse backend. Backport apache/incubator-gluten#6282. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No. Closes #2594 from SteNicholas/CELEBORN-1486. Authored-by: SteNicholas <[email protected]> Signed-off-by: xiyu.zk <[email protected]> (cherry picked from commit 5a39fc7) Signed-off-by: xiyu.zk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix
Celeborn supportof get-started document including:-Pcelebornto fix the profile of celeborn inMaven build parametersforbuild-guide.md.-Pcelebornto fix the profile of compiling the Gluten Java module inCeleborn supportforVelox.md.Celeborn supportof clickhouse backend forClickHouse.md.How was this patch tested?
No.