-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL] Daily Update Velox Version (2024_06_30) #6284
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
@marin-ma, we still need to apply some changes for arrow build (if arrow lib is not found, velox will resolve the dependency by |
ARROW_HOME needs to be set to "${VELOX_HOME}/_build/release/CMake/resolve_dependency_modules/arrow/arrow_ep/" (replace release with debug for debug mode). https://github.com/apache/incubator-gluten/blob/main/cpp/CMakeLists.txt#L71-L73 |
Signed-off-by: glutenperfbot <[email protected]>
This reverts commit 25347b2.
===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====
|
@PHILO-HE just to confirm, with this PR, how many times Arrow will be built and where it's built? |
@@ -1017,7 +1017,7 @@ class TestOperator extends VeloxWholeStageTransformerSuite with AdaptiveSparkPla | |||
} | |||
} | |||
|
|||
test("test explode/posexplode function") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marin-ma why these operators test should be ignored?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
@FelixYBW, currently, there are still two builds, since a build issue for Velox was found yesterday. We need wait for this velox pr: facebookincubator/velox#10355 |
Can we add this PR to OAP/Velox temporarily? In future if a PR from us to Velox may impact Gluten, let's submit the PR to Gluten also and make sure once Velox's PR is merged Gluten can work as expected. |
Upstream Velox's New Commits: