Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLUTEN-6288][CH] Support BroadcastNestedLoopJoinExe[Part one] #6290

Merged
merged 6 commits into from
Jul 11, 2024
Merged

[GLUTEN-6288][CH] Support BroadcastNestedLoopJoinExe[Part one] #6290

merged 6 commits into from
Jul 11, 2024

Conversation

loneylee
Copy link
Member

@loneylee loneylee commented Jul 1, 2024 •
edited
Loading

What changes were proposed in this pull request?

(Fixes: #6288)

当前PR仅支持了ch中cross join支持的部分

  • inner join 不等key关联
  • left join / right join 无key关联

已下已知会fallback的，后续陆续支持

  • left join / right join 不等key关联
  • left semi / right semi 不等key关联

How was this patch tested?

Test by ut

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024

#6288

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024

Run Gluten Clickhouse CI

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024

Run Gluten Clickhouse CI

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

Run Gluten Clickhouse CI

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Run Gluten Clickhouse CI

2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Run Gluten Clickhouse CI

@loneylee
Copy link
Member Author

Run Gluten Clickhouse CI

loneylee added 3 commits July 10, 2024 10:03
@loneylee
add bnlj
41f6daf
@loneylee
fix metric
bdda93d 
fix ci

fix velox ci

tag

fix rebase

all fallback

fix style
@loneylee
fix ci
2ac3fb9 
fix ci

fix ci 2

fix velox error
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@loneylee loneylee changed the title [GLUTEN-6288][CH] Support BroadcastNestedLoopJoinExe [GLUTEN-6288][CH] Support BroadcastNestedLoopJoinExe[Part one] Jul 11, 2024
@loneylee loneylee marked this pull request as ready for review July 11, 2024 01:51
zzcclp
zzcclp approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@zzcclp zzcclp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baibaichen baibaichen merged commit 5096d66 into apache:main Jul 11, 2024
44 checks passed
@ccat3z ccat3z mentioned this pull request Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzcclp zzcclp zzcclp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CH] Support BroadcastNestedLoopJoinExec
3 participants
@loneylee @zzcclp @baibaichen