[GLUTEN-6304][CH]Support array_join #6305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
1 similar comment
|
Run Gluten Clickhouse CI |
KevinyhZou
force-pushed
the
support_array_join
branch
from
55b11d3 to
79b4863
Compare
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
lgbo-ustc
reviewed
Jul 5, 2024
| @@ -177,7 +177,8 @@ static const std::map<std::string, std::string> SCALAR_FUNCTIONS | |||
| {"array", "array"}, | |||
| {"shuffle", "arrayShuffle"}, | |||
| {"range", "range"}, /// dummy mapping | |||
| {"flatten", "sparkArrayFlatten"}, | |||
| {"flatten", "sparkArrayFlatten"}, | |||
| {"array_join", "sparkArrayJoin"}, | |||
There was a problem hiding this comment.
Please don't add new functions by this map
There was a problem hiding this comment.
array_join not has function to map in clickhouse, it can not use function parser
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
(Fixes: #6304)
How was this patch tested?
test by spark ut