Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] build arrow first when build Velox separately. #6306

Closed
wants to merge 1 commit into from

Conversation

j7nhai
Copy link
Contributor

@j7nhai j7nhai commented Jul 2, 2024

What changes were proposed in this pull request?

Should build arrow first when build Velox separately.

How was this patch tested?

manually

Copy link

github-actions bot commented Jul 2, 2024

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@PHILO-HE
Copy link
Contributor

PHILO-HE commented Jul 3, 2024

@j7nhai, could you let me know the build error you meet? I think building velox doesn't require builing arrow must be done firstly.

Copy link
Contributor

@Yohahaha Yohahaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@FelixYBW
Copy link
Contributor

FelixYBW commented Jul 3, 2024

What's the script when you build Velox? Did you apply Gluten's velox patch when you build velox?

@j7nhai
Copy link
Contributor Author

j7nhai commented Jul 8, 2024

Actually, build Velox script includes building Arrow. The error I encountered before was that the arrow jar was not installed in the system. Maybe it was accidental.

@j7nhai j7nhai closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants