Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Add isStreamingAgg info to HashAggregateTransformer #6307

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

liujiayi771
Copy link
Contributor

What changes were proposed in this pull request?

Add isStreamingAgg info to the toString method of HashAggregateBaseTransformer, so that we can easily determine the current type of the Aggregate.

How was this patch tested?

N/A.

Copy link

github-actions bot commented Jul 2, 2024

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@liujiayi771
Copy link
Contributor Author

cc @ulysses-you, thanks.

Copy link

github-actions bot commented Jul 2, 2024

Run Gluten Clickhouse CI

@liujiayi771
Copy link
Contributor Author

By adding this info, we can determine if #3828 is effective.

image

@liujiayi771 liujiayi771 requested a review from ulysses-you July 2, 2024 06:28
Copy link
Contributor

@ulysses-you ulysses-you left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you

@ulysses-you ulysses-you merged commit f9bd490 into apache:main Jul 2, 2024
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants