[CORE] Minor code cleanups against fallback tagging #6320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI |
zhztheplayer
force-pushed
the
wip-refactor-validate
branch
from
bab1095 to
be562d3
Compare
|
Run Gluten Clickhouse CI |
1 similar comment
|
Run Gluten Clickhouse CI |
zhztheplayer
force-pushed
the
wip-refactor-validate
branch
from
756fe12 to
8583e1e
Compare
|
Run Gluten Clickhouse CI |
zhztheplayer
force-pushed
the
wip-refactor-validate
branch
from
8583e1e to
917653a
Compare
|
Run Gluten Clickhouse CI |
3 similar comments
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
zhztheplayer
force-pushed
the
wip-refactor-validate
branch
from
1ade079 to
79cfdfc
Compare
|
Run Gluten Clickhouse CI |
zhztheplayer
force-pushed
the
wip-refactor-validate
branch
from
79cfdfc to
2b8c959
Compare
|
Run Gluten Clickhouse CI |
5 similar comments
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
zhztheplayer
force-pushed
the
wip-refactor-validate
branch
from
cfe3217 to
2600f06
Compare
|
Run Gluten Clickhouse CI |
zhztheplayer
force-pushed
the
wip-refactor-validate
branch
from
2600f06 to
b847673
Compare
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
JkSelf
approved these changes
Jul 12, 2024
PHILO-HE
approved these changes
Jul 12, 2024
yma11
added a commit
to yma11/gluten
that referenced
this pull request
Jul 15, 2024
)" This reverts commit 2f35c63.
yma11
added a commit
to yma11/gluten
that referenced
this pull request
Jul 15, 2024
)" This reverts commit 2f35c63.
yma11
added a commit
to yma11/gluten
that referenced
this pull request
Jul 15, 2024
)" This reverts commit 2f35c63.
yma11
added a commit
to yma11/gluten
that referenced
this pull request
Jul 15, 2024
)" This reverts commit 2f35c63.
yma11
added a commit
to yma11/gluten
that referenced
this pull request
Jul 15, 2024
)" This reverts commit 2f35c63.
zhztheplayer
added a commit
to zhztheplayer/gluten
that referenced
this pull request
Jul 16, 2024
)" This reverts commit 2f35c63.
yma11
added a commit
to yma11/gluten
that referenced
this pull request
Jul 16, 2024
)" This reverts commit 2f35c63.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ValidationResult.oktoValidationResult.succeededValidationResult.notOk(reason)toValidationResult.failed(reason)ValidationResult.isValid()toValidationResult.ok()FALLBACK_REASON_TAG, reuseFallbackTaginsteadFallbackTag.Converterto convert from different inputs toFallbackTaginstances implicitly