Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] RAS: Remove NoopFilter if has same output with child #6324

Merged
merged 3 commits into from
Jul 4, 2024
Merged

[VL] RAS: Remove NoopFilter if has same output with child #6324

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
632061e
[VL] RAS: Remove NoopFilter if has same output with child
zml1206 Jul 3, 2024
0ca22a8
Merge branch 'main' into ras_remove_filter
zml1206 Jul 3, 2024
68a019c
update
zml1206 Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions ...en-core/src/main/scala/org/apache/gluten/extension/columnar/enumerated/RemoveFilter.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,13 @@ object RemoveFilter extends RasRule[SparkPlan] {
override def shift(node: SparkPlan): Iterable[SparkPlan] = {
val filter = node.asInstanceOf[FilterExecTransformerBase]
if (filter.isNoop()) {
val out = NoopFilter(filter.child, filter.output)
out.copyTagsFrom(filter)
return List(out)
if (filter.output == filter.child.output) {
return List(filter.child)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s invert the if condition. Also avoid adding ‘else’ clause as ‘return’ is already used.

} else {
val out = NoopFilter(filter.child, filter.output)
out.copyTagsFrom(filter)
return List(out)
}
}
List.empty
}
Expand Down
Loading