Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Spark assert_true function support #6329

Merged
merged 8 commits into from
Jul 11, 2024

Conversation

gaoyangxiaozhu
Copy link
Contributor

@gaoyangxiaozhu gaoyangxiaozhu commented Jul 4, 2024

Copy link

github-actions bot commented Jul 4, 2024

Run Gluten Clickhouse CI

1 similar comment
Copy link

github-actions bot commented Jul 5, 2024

Run Gluten Clickhouse CI

@gaoyangxiaozhu gaoyangxiaozhu force-pushed the gayangya/assert_true branch from 4920289 to e667e65 Compare July 5, 2024 09:32
Copy link

github-actions bot commented Jul 5, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Jul 6, 2024

Run Gluten Clickhouse CI

1 similar comment
Copy link

github-actions bot commented Jul 9, 2024

Run Gluten Clickhouse CI

@gaoyangxiaozhu gaoyangxiaozhu force-pushed the gayangya/assert_true branch from de1c00b to 0e286d7 Compare July 9, 2024 08:56
Copy link

github-actions bot commented Jul 9, 2024

Run Gluten Clickhouse CI

@gaoyangxiaozhu gaoyangxiaozhu force-pushed the gayangya/assert_true branch from 0e286d7 to 247878c Compare July 9, 2024 12:13
Copy link

github-actions bot commented Jul 9, 2024

Run Gluten Clickhouse CI

@gaoyangxiaozhu gaoyangxiaozhu changed the title [VL][WIP] Spark assert_true function support [VL] Spark assert_true function support Jul 9, 2024
@gaoyangxiaozhu
Copy link
Contributor Author

gaoyangxiaozhu commented Jul 9, 2024

@PHILO-HE / @rui-mo / @FelixYBW help review.

@gaoyangxiaozhu
Copy link
Contributor Author

@PHILO-HE / @rui-mo help review.

ping~

@zhztheplayer
Copy link
Member

@gaoyangxiaozhu Would you like to rebase ? Thanks.

@apache apache deleted a comment from github-actions bot Jul 11, 2024
Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One minor comment.

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

@gaoyangxiaozhu gaoyangxiaozhu requested a review from PHILO-HE July 11, 2024 06:11
@gaoyangxiaozhu
Copy link
Contributor Author

@PHILO-HE help sign and merge, thanks!

@PHILO-HE PHILO-HE merged commit 6f189c7 into apache:main Jul 11, 2024
41 checks passed
yma11 added a commit to yma11/gluten that referenced this pull request Jul 15, 2024
yma11 added a commit to yma11/gluten that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants