Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Deduplicate sorting keys #6332

Merged
merged 2 commits into from
Jul 5, 2024
Merged

[VL] Deduplicate sorting keys #6332

merged 2 commits into from
Jul 5, 2024

Conversation

ulysses-you
Copy link
Contributor

What changes were proposed in this pull request?

Deduplicate sorting keys before going to Velox.

How was this patch tested?

add test & pass exist tests

Copy link

github-actions bot commented Jul 4, 2024

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@ulysses-you ulysses-you force-pushed the sort branch 3 times, most recently from cc47158 to 67c97aa Compare July 5, 2024 01:52
Copy link

github-actions bot commented Jul 5, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Jul 5, 2024

Run Gluten Clickhouse CI

@ulysses-you
Copy link
Contributor Author

cc @marin-ma thank you

@ulysses-you
Copy link
Contributor Author

thank you @PHILO-HE

@ulysses-you ulysses-you merged commit ef424aa into apache:main Jul 5, 2024
43 checks passed
@ulysses-you ulysses-you deleted the sort branch July 5, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants