Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Minor refactor for ValueStream node construction and usage #6382

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

Yohahaha
Copy link
Contributor

@Yohahaha Yohahaha commented Jul 9, 2024

Refactor ValueStream node construction logic and add finished flag for it.

Copy link

github-actions bot commented Jul 9, 2024

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@Yohahaha
Copy link
Contributor Author

cc @liujiayi771 @PHILO-HE thank you!

@liujiayi771
Copy link
Contributor

@Yohahaha Could you add some details in the description?

@Yohahaha
Copy link
Contributor Author

@Yohahaha Could you add some details in the description?

done

@Yohahaha Yohahaha merged commit 7467fe4 into apache:main Jul 10, 2024
42 checks passed
@Yohahaha Yohahaha deleted the refine-valuestream branch July 10, 2024 07:32
zsmj2017 pushed a commit to zsmj2017/incubator-gluten that referenced this pull request Nov 11, 2024
zsmj2017 pushed a commit to zsmj2017/incubator-gluten that referenced this pull request Nov 12, 2024
zhztheplayer pushed a commit to zhztheplayer/gluten that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants