-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CH][CELEBORN] CHCelebornColumnarBatchSerializer uses AtomicBoolean to identify whether to call close() to avoid calling close() twice situation #6455
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
94ebbb5
to
091630c
Compare
…o identify whether to call close() to avoid calling close() twice situation
091630c
to
2a8aa0a
Compare
Run Gluten Clickhouse CI |
Ping @taiyang-li, @zzcclp, @zhztheplayer. |
Let's wait for ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
What changes were proposed in this pull request?
CHCelebornColumnarBatchSerializer
should useAtomicBoolean
to identify whether to callclose()
to avoid callingclose()
twice situation which causes the replication of metrics likereadBatchNumRows
,numOutputRows
.How was this patch tested?
CI.