Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Do not pushdown filters with HUGEINT columns #6464

Closed
wants to merge 1 commit into from
Closed

[VL] Do not pushdown filters with HUGEINT columns #6464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions cpp/velox/substrait/SubstraitToVeloxPlan.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1737,6 +1737,7 @@ void SubstraitToVeloxPlanConverter::separateFilters(
// Check if the condition is supported to be pushed down.
uint32_t fieldIdx;
if (canPushdownFunction(scalarFunction, filterName, fieldIdx) &&
veloxTypeList[fieldIdx]->kind() != TypeKind::HUGEINT &&
rangeRecorders.at(fieldIdx).setCertainRangeForFunction(filterName)) {
subfieldFunctions.emplace_back(scalarFunction);
} else {
Expand Down Expand Up @@ -2141,10 +2142,7 @@ void SubstraitToVeloxPlanConverter::constructSubfieldFilters(
bool existIsNullAndIsNotNull = filterInfo.forbidsNullSet_ && filterInfo.isNullSet_;
uint32_t rangeSize = std::max(filterInfo.lowerBounds_.size(), filterInfo.upperBounds_.size());

if constexpr (KIND == facebook::velox::TypeKind::HUGEINT) {
// TODO: open it when the Velox's modification is ready.
VELOX_NYI("constructSubfieldFilters not support for HUGEINT type");
} else if constexpr (KIND == facebook::velox::TypeKind::BOOLEAN) {
if constexpr (KIND == facebook::velox::TypeKind::BOOLEAN) {
// Handle bool type filters.
// Not equal.
if (filterInfo.notValue_) {
Expand Down Expand Up @@ -2381,10 +2379,11 @@ connector::hive::SubfieldFilters SubstraitToVeloxPlanConverter::mapToFilters(
constructSubfieldFilters<TypeKind::VARCHAR, common::Filter>(
colIdx, inputNameList[colIdx], inputType, columnToFilterInfo[colIdx], filters);
break;
case TypeKind::HUGEINT:
constructSubfieldFilters<TypeKind::HUGEINT, common::HugeintRange>(
colIdx, inputNameList[colIdx], inputType, columnToFilterInfo[colIdx], filters);
break;
// If support pushing down HUGEINT filters, we can open it
// case TypeKind::HUGEINT:
// constructSubfieldFilters<TypeKind::HUGEINT, common::HugeintRange>(
// colIdx, inputNameList[colIdx], inputType, columnToFilterInfo[colIdx], filters);
// break;
case TypeKind::ARRAY:
constructSubfieldFilters<TypeKind::ARRAY, common::Filter>(
colIdx, inputNameList[colIdx], inputType, columnToFilterInfo[colIdx], filters);
Expand Down
Loading