[GLUTEN-6487][VL] ColumnarBatchOutIterator should be interruptible iterator #6488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI |
WangGuangxin
force-pushed
the
fix_interrupt
branch
from
9a895f4 to
007b933
Compare
WangGuangxin
force-pushed
the
fix_interrupt
branch
from
007b933 to
5dd0e8a
Compare
|
Run Gluten Clickhouse CI |
1 similar comment
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Would you please help check if this API can be used to acheive the same? Thanks. |
@zhztheplayer I double checked that it's works now, the root cause for my case is because a single |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The
ColumnarBatchOutIteratorshould check whether the task is interrupted, so that speculation tasks can end as soon as possible.Since when
Thread.interrupt()is called and it's in a JNI call, theInterruptedExceptionis not thrown, then we need to check the interrupt status.A case in our env is the speculation task run for 2 hours, but in fact, the task with attempt id = 0 has already fininshed 1.5 hours ago.
(Fixes: #6487)
How was this patch tested?
Mannually