Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUEN-6506][CH]Fix ORC read wrong timestamp value #6507

Merged
merged 5 commits into from
Aug 12, 2024

Conversation

KevinyhZou
Copy link
Contributor

@KevinyhZou KevinyhZou commented Jul 18, 2024

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

(Fixes: #6506)

related to pr: ClickHouse/ClickHouse#67175

How was this patch tested?

test by ut

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

2 similar comments
Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Aug 2, 2024

Run Gluten Clickhouse CI

@KevinyhZou KevinyhZou force-pushed the fix_orc_read_timezone branch from 6616a11 to 193f691 Compare August 5, 2024 02:45
@github-actions github-actions bot added the CORE works for Gluten Core label Aug 5, 2024
Copy link

github-actions bot commented Aug 5, 2024

Run Gluten Clickhouse CI

@KevinyhZou KevinyhZou force-pushed the fix_orc_read_timezone branch from 193f691 to f7e6ee7 Compare August 5, 2024 02:53
@github-actions github-actions bot removed the CORE works for Gluten Core label Aug 5, 2024
Copy link

github-actions bot commented Aug 5, 2024

Run Gluten Clickhouse CI

3 similar comments
Copy link

github-actions bot commented Aug 5, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Aug 8, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Aug 9, 2024

Run Gluten Clickhouse CI

@KevinyhZou KevinyhZou force-pushed the fix_orc_read_timezone branch from 52e5cd5 to 2f607c4 Compare August 9, 2024 07:15
Copy link

github-actions bot commented Aug 9, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Aug 9, 2024

Run Gluten Clickhouse CI

Copy link
Contributor

@liuneng1994 liuneng1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuneng1994 liuneng1994 merged commit 352b91e into apache:main Aug 12, 2024
8 checks passed
sharkdtu pushed a commit to sharkdtu/gluten that referenced this pull request Nov 11, 2024
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)

(Fixes: apache#6506)

related to pr: ClickHouse/ClickHouse#67175

How was this patch tested?
test by ut
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CH] ORC read wrong timestamp value
2 participants