Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Validate binary expressions with their accepted types #6521

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

PHILO-HE
Copy link
Contributor

What changes were proposed in this pull request?

How was this patch tested?

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

@PHILO-HE PHILO-HE force-pushed the verify-more-expressions branch from fe3521a to c8b27a3 Compare August 13, 2024 11:31
@github-actions github-actions bot added the CORE works for Gluten Core label Aug 13, 2024
Copy link

Run Gluten Clickhouse CI

@PHILO-HE PHILO-HE force-pushed the verify-more-expressions branch from c8b27a3 to 2e952cf Compare August 13, 2024 11:36
Copy link

Run Gluten Clickhouse CI

1 similar comment
Copy link

Run Gluten Clickhouse CI

@PHILO-HE PHILO-HE force-pushed the verify-more-expressions branch from dea5163 to 3a9d5b9 Compare August 14, 2024 06:08
Copy link

Run Gluten Clickhouse CI

@PHILO-HE PHILO-HE force-pushed the verify-more-expressions branch from 3a9d5b9 to 84708d8 Compare August 14, 2024 06:43
Copy link

Run Gluten Clickhouse CI

@PHILO-HE PHILO-HE marked this pull request as ready for review August 14, 2024 08:39
@PHILO-HE PHILO-HE changed the title [VL] Validate more expressions with their accepted types [VL] Validate binary expressions with their accepted types Aug 14, 2024
@PHILO-HE PHILO-HE merged commit da47112 into apache:main Aug 14, 2024
44 checks passed
sharkdtu pushed a commit to sharkdtu/gluten that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE works for Gluten Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants