[VL] Following #6526, minor fixes and improvements #6554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
FelixYBW
reviewed
Jul 23, 2024
cpp/core/memory/AllocationListener.h
Outdated
| @@ -87,11 +73,28 @@ class BlockAllocationListener final : public AllocationListener { | |||
| } | |||
|
|
|||
| private: | |||
| int64_t reserve(int64_t diff) { | |||
FelixYBW
reviewed
Jul 24, 2024
| if (peakBytes_.compare_exchange_weak(savedPeakBytes, usedBytes_)) { | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
With C++26 in future, we can use fetch_max directly. https://en.cppreference.com/w/cpp/atomic/atomic/fetch_max
FelixYBW
reviewed
Jul 24, 2024
| if (peakBytes_.compare_exchange_weak(savedPeakBytes, usedBytes_)) { | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
With C++26 in future, we can use fetch_max directly. https://en.cppreference.com/w/cpp/atomic/atomic/fetch_max
FelixYBW
approved these changes
Jul 24, 2024
weiting-chen
pushed a commit
to weiting-chen/gluten
that referenced
this pull request
Jul 25, 2024
weiting-chen
pushed a commit
to weiting-chen/gluten
that referenced
this pull request
Jul 25, 2024
weiting-chen
added a commit
that referenced
this pull request
Jul 25, 2024
* [GLUTEN-6501][VL] Fix the missing fileReadProperties when constructing a LocalFilesNode (#6503) * [GLUTEN-6477][VL] Fix occasional dead lock during spilling (#6515) * [VL] Add thread_safe to several VeloxRuntime classes (#6526) VeloxRuntime is shared by many threads, like task threads or parquet writter threads. We must make sure the objects hold by VeloxRuntime are thread safe. * [VL] Following #6526, minor fixes and improvements (#6554) --------- Co-authored-by: zhaokuo <[email protected]> Co-authored-by: Hongze Zhang <[email protected]> Co-authored-by: BInwei Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to #6526
diff < 0anddiff > 0so simplifies codepeakBytes_.store(std::max(peakBytes_.load(), usedBytes_.load()))is still not atomic so needs to be locked