[VL] Add config for show velox task metrics when finished #6573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI |
|
Can we use kDebugModeEnabled? |
kDebugModeEnabled still works but it's a coarse-grained config, new config aims to show more details for production job. |
|
Run Gluten Clickhouse CI |
|
cc @ulysses-you @liujiayi771 thank you! |
FelixYBW
approved these changes
Jul 24, 2024
weiting-chen
pushed a commit
to weiting-chen/gluten
that referenced
this pull request
Nov 19, 2024
weiting-chen
added a commit
that referenced
this pull request
Nov 20, 2024
* [GLUTEN-7024][VL] Skip call collectMetrics when the task does not call next() (#7025) * [GLUTEN-7130][CORE] Skip command execution when collect qe fallback summary (#7132) * [VL] Add config for show velox task metrics when finished (#6573) --------- Co-authored-by: zhaokuo <[email protected]> Co-authored-by: Zhen Wang <[email protected]> Co-authored-by: Yang Zhang <[email protected]>
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add config
spark.gluten.sql.columnar.backend.velox.showTaskMetricsWhenFinishedfor show velox task metrics when finished, it helps debug task level execution.