Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLUTEN-6550] Fix build failure when BUILD_TESTS is enabled on macOS #6594

Closed
wants to merge 1 commit into from
Closed

[GLUTEN-6550] Fix build failure when BUILD_TESTS is enabled on macOS #6594

wants to merge 1 commit into from

Conversation

xumingming
Copy link
Contributor

(Fixes: #6550)

@github-actions GitHub Actions
Copy link

#6550

@xumingming xumingming force-pushed the fix-tests-build-on-macos-2 branch from bb81d54 to 8b98618 Compare July 25, 2024 12:01
@xumingming xumingming force-pushed the fix-tests-build-on-macos-2 branch from 8b98618 to 2cb9808 Compare August 5, 2024 06:10
@github-actions github-actions bot added the VELOX label Aug 5, 2024
@xumingming
Copy link
Contributor Author

@PHILO-HE Can you help review this one?

PHILO-HE
PHILO-HE previously approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xumingming, looks good!

@PHILO-HE
Copy link
Contributor

PHILO-HE commented Aug 6, 2024

@xumingming, CI is red.

2024-08-06T05:06:16.2344593Z /__w/incubator-gluten/incubator-gluten/cpp/core/benchmarks/CompressionBenchmark.cc: In member function 'void gluten::BenchmarkCompression::setCpu(uint32_t)':
2024-08-06T05:06:16.2347628Z /__w/incubator-gluten/incubator-gluten/cpp/core/benchmarks/CompressionBenchmark.cc:218:42: error: 'std::thread' has not been declared
2024-08-06T05:06:16.2349500Z   218 |     static const auto kTotalCores = std::thread::hardware_concurrency();
2024-08-06T05:06:16.2350614Z       |                                          ^~~~~~
2024-08-06T05:06:16.2357924Z make[2]: *** [core/benchmarks/CMakeFiles/BenchmarkCompression.dir/build.make:76: core/benchmarks/CMakeFiles/BenchmarkCompression.dir/CompressionBenchmark.cc.o] Error 1

@xumingming xumingming force-pushed the fix-tests-build-on-macos-2 branch 4 times, most recently from de92aeb to 0ba176a Compare August 17, 2024 01:59
@xumingming xumingming force-pushed the fix-tests-build-on-macos-2 branch from 0ba176a to 7b029bb Compare August 17, 2024 07:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale stale label Oct 2, 2024
@github-actions GitHub Actions
Copy link

This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks.

@github-actions github-actions bot closed this Oct 13, 2024
@wForget
Copy link
Member

wForget commented Jan 8, 2025

I get the same failure building on macos, what is blocking this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PHILO-HE PHILO-HE PHILO-HE left review comments

Assignees
No one assigned
Labels
stale stale VELOX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build fails on macOS when enable BUILD_TESTS
3 participants
@xumingming @PHILO-HE @wForget