Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-6561][CH] Fix incompatiable type exception throw in capture function while processing array literal with transform #6601

Merged
merged 7 commits into from
Jul 30, 2024

Conversation

taiyang-li
Copy link
Contributor

What changes were proposed in this pull request?

(Fixes: #6561)

@taiyang-li taiyang-li marked this pull request as draft July 26, 2024 02:37
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

@taiyang-li taiyang-li changed the title [Gluten-6561][CH] Fix incompatiable type throw in capture function when process array literal with array high order function like transform/filter/aggregate/sort [Gluten-6561][CH] Fix incompatiable type throw in capture function when process array literal with transform Jul 26, 2024
@taiyang-li taiyang-li changed the title [Gluten-6561][CH] Fix incompatiable type throw in capture function when process array literal with transform [GLUTEN-6561][CH] Fix incompatiable type throw in capture function when process array literal with transform Jul 26, 2024
Copy link

#6561

@taiyang-li taiyang-li marked this pull request as ready for review July 26, 2024 04:35
@taiyang-li
Copy link
Contributor Author

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

@taiyang-li taiyang-li requested a review from baibaichen July 26, 2024 07:49
@taiyang-li taiyang-li changed the title [GLUTEN-6561][CH] Fix incompatiable type throw in capture function when process array literal with transform [GLUTEN-6561][CH] Fix incompatiable type throw in capture function while processing array literal with transform Jul 26, 2024
@taiyang-li taiyang-li changed the title [GLUTEN-6561][CH] Fix incompatiable type throw in capture function while processing array literal with transform [GLUTEN-6561][CH] Fix incompatiable type exception throw in capture function while processing array literal with transform Jul 26, 2024
Copy link

Run Gluten Clickhouse CI

@baibaichen
Copy link
Contributor

@taiyang-li

It's better to add more UTs.

Copy link

Run Gluten Clickhouse CI

@baibaichen
Copy link
Contributor

@taiyang-li why ignore test?

Copy link

Run Gluten Clickhouse CI

Copy link
Contributor

@baibaichen baibaichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baibaichen baibaichen merged commit dba4439 into apache:main Jul 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CH] transform with map_keys and map_values failed.
2 participants