Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Support Sum(Literal)/Count(Literal) with empty input schema #6631

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

zml1206
Copy link
Contributor

@zml1206 zml1206 commented Jul 30, 2024

What changes were proposed in this pull request?

How was this patch tested?

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@zml1206
Copy link
Contributor Author

zml1206 commented Jul 31, 2024

cc @PHILO-HE thank you

@PHILO-HE PHILO-HE changed the title [VL] Support Sum(Literal) when children has empty output [VL] Support Sum(Literal)/Count(Literal) with empty input schema Jul 31, 2024
Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PHILO-HE PHILO-HE merged commit cff5de5 into apache:main Jul 31, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants