[VL] Support date type in window range frame #6651
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI |
JkSelf
commented
Jul 31, 2024
|
|
||
| /** Types that include numeric types and ANSI interval types. */ | ||
| val NumericAndAnsiInterval = | ||
| TypeCollection(NumericType, DayTimeIntervalType, YearMonthIntervalType, DateType) |
There was a problem hiding this comment.
Add the DateType in NumericAndAnsiInterval.
There was a problem hiding this comment.
I think rewrite AbstractDataType is not a good idea. The first point is unstable because there may be class loading order problems. The second point may affect the results of other uses of this method. I used the method of rewrite orderSpec in #6653. What do you think？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Follow up #6637. In order to enable support for the date type within the window range frame, it is necessary to incorporate the date type into the Spark codebase, specifically within the AbstractDataType.scala file located at here. To achieve this, we have added the AbstractDataType file to the shim folder.
How was this patch tested?
Adding new tests.