[VL] Doc: Update RSS docs #6692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
wForget
changed the title
wForget
commented
Aug 2, 2024
| @@ -298,7 +298,7 @@ spark.shuffle.service.enabled false | |||
| spark.rss.storage.type LOCALFILE_HDFS | |||
|
|
|||
| # If you want to use dynamic resource allocation, | |||
| # please refer to this URL (https://github.com/apache/incubator-uniffle/tree/master/patch/spark) to apply the patch into your own Spark. | |||
| # please refer to this URL (https://uniffle.apache.org/docs/client-guide#support-spark-dynamic-allocation) for more details. | |||
There was a problem hiding this comment.
Updated uniffle website related documents: apache/uniffle-website#83
zhztheplayer
changed the title
zhztheplayer
reviewed
Aug 6, 2024
docs/get-started/Velox.md
Outdated
| @@ -279,7 +279,7 @@ mvn clean package -Pbackends-velox -Pspark-3.3 -Puniffle -DskipTests | |||
| Then add the Uniffle and Spark Celeborn Client packages to your Spark application's classpath(usually add them into `$SPARK_HOME/jars`). | |||
|
|
|||
| - Uniffle: rss-client-spark3-shaded-[uniffleVersion].jar | |||
| - Gluten: gluten-uniffle-velox-xxx-SNAPSHOT-3.x.jar | |||
| - Gluten: gluten-velox-bundle-spark3.x_2.12-xx_xx_xx-SNAPSHOT.jar (When `-Puniffle` is specified the gluten bundle jar includes `gluten-uniffle-package`.) | |||
There was a problem hiding this comment.
When
-Puniffleis specified the gluten bundle jar includesgluten-uniffle-package.
Would you reword to something like
The bundled Gluten Jar. Make sure
-Puniffleis specified when it is built.
There was a problem hiding this comment.
SGTM, changed, thank you.
zhztheplayer
approved these changes
Aug 7, 2024
FMX
pushed a commit
to apache/celeborn
that referenced
this pull request
Sep 26, 2024
…lox and Get Started With ClickHouse in glutensupport.md ### What changes were proposed in this pull request? Update document link of `Get Started With Velox` and `Get Started With ClickHouse` in `glutensupport.md`. Meanwhile, replace `gluten-celeborn-package-xx-SNAPSHOT.jar` with `(The bundled Gluten Jar. Make sure -Pceleborn is specified when it is built.)`, which refers to apache/incubator-gluten#6692. ### Why are the changes needed? The document link of `Get Started With Velox` and `Get Started With ClickHouse` could not access, which has already changed the url. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No. Closes #2762 from SteNicholas/CELEBORN-1486. Authored-by: SteNicholas <[email protected]> Signed-off-by: mingji <[email protected]>
HolyLow
pushed a commit
to HolyLow/celeborn
that referenced
this pull request
Oct 14, 2024
…lox and Get Started With ClickHouse in glutensupport.md ### What changes were proposed in this pull request? Update document link of `Get Started With Velox` and `Get Started With ClickHouse` in `glutensupport.md`. Meanwhile, replace `gluten-celeborn-package-xx-SNAPSHOT.jar` with `(The bundled Gluten Jar. Make sure -Pceleborn is specified when it is built.)`, which refers to apache/incubator-gluten#6692. ### Why are the changes needed? The document link of `Get Started With Velox` and `Get Started With ClickHouse` could not access, which has already changed the url. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No. Closes apache#2762 from SteNicholas/CELEBORN-1486. Authored-by: SteNicholas <[email protected]> Signed-off-by: mingji <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Update velox doc
How was this patch tested?
no