-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL] Minor follow-ups for PRs #6693
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
Run Gluten Clickhouse CI |
As I documented, since the slice has little overhead, let's just honor the max batch size as 1x. |
If I remember correctly in our code there were some places producing columnar batches that use default batch size |
Run Gluten Clickhouse CI |
2 similar comments
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
b7d6b83
to
1ce002c
Compare
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
spark.gluten.sql.columnar.backend.velox.resizeBatches.shuffleInput.range
spark.gluten.sql.columnar.backend.velox.resizeBatches.shuffleInput.minSize
JavaModuleOptions
are passed to executors in local cluster mode, we'd align executors' and driver's options in that mode.