Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-6695][CH] Introduce shuffleWallTime in CHMetricsApi to calculate the overall shuffle write time #6696

Merged
merged 1 commit into from
Aug 4, 2024

Conversation

SteNicholas
Copy link
Member

@SteNicholas SteNicholas commented Aug 2, 2024

What changes were proposed in this pull request?

VeloxCelebornColumnarShuffleWriter supports shuffleWallTime metric of VeloxMetricsApi to calculate the overall shuffle write time for columnar shuffle exchange metrics in #6579. Therefore, CHCelebornColumnarShuffleWriter should also support shuffleWallTime to calculate the overall shuffle write time.

(Fixes: #6695)

How was this patch tested?

CI.

Copy link

github-actions bot commented Aug 2, 2024

#6695

Copy link

github-actions bot commented Aug 2, 2024

Run Gluten Clickhouse CI

@SteNicholas
Copy link
Member Author

Ping @taiyang-li, @marin-ma.

Copy link

github-actions bot commented Aug 2, 2024

Run Gluten Clickhouse CI

Copy link
Contributor

@taiyang-li taiyang-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baibaichen baibaichen merged commit 944c926 into apache:main Aug 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CH] Introduce shuffleWallTime in CHMetricsApi to calculate the overall shuffle write time
3 participants