[GLUTEN-6656][UNIFFLE] VeloxUniffleColumnarShuffleWriter should send commit for all ColumnBatch with empty rows #6698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteNicholas
force-pushed
the
GLUTEN-6656
branch
from
1d3dd91 to
d162899
Compare
|
Ping @exmy, @jackylee-ch, @summaryzb. |
SteNicholas
force-pushed
the
GLUTEN-6656
branch
from
d162899 to
ddf52b1
Compare
xianjingfeng
reviewed
Aug 2, 2024
...e/velox/src/main/java/org/apache/spark/shuffle/writer/VeloxUniffleColumnarShuffleWriter.java
Outdated
Show resolved
Hide resolved
|
I'm ok with this fix |
SteNicholas
force-pushed
the
GLUTEN-6656
branch
from
ddf52b1 to
f462c87
Compare
SteNicholas
force-pushed
the
GLUTEN-6656
branch
from
f462c87 to
5d301ca
Compare
…commit for all ColumnBatch with empty rows
SteNicholas
force-pushed
the
GLUTEN-6656
branch
from
5d301ca to
28e781c
Compare
|
@jackylee-ch, PTAL. |
This was referenced Oct 17, 2024
weiting-chen
pushed a commit
to weiting-chen/gluten
that referenced
this pull request
Nov 19, 2024
…commit for all ColumnBatch with empty rows (apache#6698)
This was referenced Nov 19, 2024
PHILO-HE
pushed a commit
that referenced
this pull request
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When all of the ColumnarBatch have empty rows in
VeloxUniffleColumnarShuffleWriter, thenativeShuffleWriteris not initialized and causesIllegalStateException.VeloxUniffleColumnarShuffleWritershould send commit for allColumnBatchwith empty rows.Follow up #6657.
(Fixes: #6656)
How was this patch tested?
CI.