-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-6701][CH] fix: Performace regression at 20240802 daily build #6702
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
Run Gluten Clickhouse CI |
8b6e0b0
to
f35e01c
Compare
Run Gluten Clickhouse CI |
f35e01c
to
27c49bf
Compare
Run Gluten Clickhouse CI |
By reverting #6659 and #6677, The perfromance is good let's try only revert #6659 OK let's try only revert #6677 It looks both PRs have an impact on performance, but #6677 clearly has the greatest impact, let's revert it first. |
This reverts commit e472e5d.
27c49bf
to
6583bff
Compare
Run Gluten Clickhouse CI |
What changes were proposed in this pull request?
Revert #6677
(Fixes: #6701)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)