Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-6724][CH] Shuffle writer supports compression level configuration for CompressionCodecFactory #6725

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

SteNicholas
Copy link
Member

What changes were proposed in this pull request?

ShuffleWriter and PartitionWriter do not support compression level configuration in Clickhouse. Meanwhile, CompressionCodecFactory supports setting compression level. Therefore, shuffle writer supports compression level configuration for CompressionCodecFactory in Clickhouse backend.

(Fixes: #6724)

How was this patch tested?

CI.

Copy link

github-actions bot commented Aug 6, 2024

#6724

Copy link

github-actions bot commented Aug 6, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Aug 6, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Aug 6, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Aug 6, 2024

Run Gluten Clickhouse CI

@SteNicholas SteNicholas marked this pull request as draft August 6, 2024 10:15
Copy link

github-actions bot commented Aug 6, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Aug 6, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Aug 6, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Aug 6, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Aug 6, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Aug 6, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Aug 6, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Aug 7, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Aug 8, 2024

Run Gluten Clickhouse CI

@SteNicholas SteNicholas marked this pull request as ready for review August 8, 2024 06:18
@SteNicholas
Copy link
Member Author

Ping @taiyang-li, @baibaichen.

Copy link

github-actions bot commented Aug 9, 2024

Run Gluten Clickhouse CI

@SteNicholas SteNicholas requested a review from taiyang-li August 9, 2024 05:35
Copy link
Contributor

@taiyang-li taiyang-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taiyang-li taiyang-li requested a review from zhouyuan August 9, 2024 06:31
@SteNicholas
Copy link
Member Author

@zhouyuan, PTAL.

Copy link
Contributor

@zhouyuan zhouyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zhouyuan
Copy link
Contributor

zhouyuan commented Aug 9, 2024

CC @marin-ma

@SteNicholas
Copy link
Member Author

@marin-ma, PTAL.

@taiyang-li taiyang-li merged commit da9c2fa into apache:main Aug 12, 2024
44 checks passed
sharkdtu pushed a commit to sharkdtu/gluten that referenced this pull request Nov 11, 2024
…tion for CompressionCodecFactory (apache#6725)

* [GLUTEN-6724][CH] Shuffle writer supports compression level configuration for CompressionCodecFactory

* [GLUTEN-6724][CH] Shuffle writer supports compression level configuration for CompressionCodecFactory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CH] Shuffle writer supports compression level configuration for CompressionCodecFactory
3 participants