-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-6724][CH] Shuffle writer supports compression level configuration for CompressionCodecFactory #6725
Conversation
Run Gluten Clickhouse CI |
ca62744
to
5e747a2
Compare
Run Gluten Clickhouse CI |
5e747a2
to
6b3e3cb
Compare
Run Gluten Clickhouse CI |
6b3e3cb
to
9464558
Compare
Run Gluten Clickhouse CI |
9464558
to
65e1686
Compare
Run Gluten Clickhouse CI |
65e1686
to
991ce75
Compare
Run Gluten Clickhouse CI |
991ce75
to
c464375
Compare
Run Gluten Clickhouse CI |
c464375
to
989b1aa
Compare
Run Gluten Clickhouse CI |
989b1aa
to
a2c1ad4
Compare
Run Gluten Clickhouse CI |
a2c1ad4
to
93dadec
Compare
Run Gluten Clickhouse CI |
93dadec
to
3b5d9ed
Compare
Run Gluten Clickhouse CI |
3b5d9ed
to
6398af2
Compare
Run Gluten Clickhouse CI |
…tion for CompressionCodecFactory
6398af2
to
7232d4d
Compare
Run Gluten Clickhouse CI |
Ping @taiyang-li, @baibaichen. |
backends-clickhouse/src/main/scala/org/apache/gluten/vectorized/CHColumnarBatchSerializer.scala
Outdated
Show resolved
Hide resolved
backends-clickhouse/src/main/scala/org/apache/spark/shuffle/CHColumnarShuffleWriter.scala
Outdated
Show resolved
Hide resolved
backends-clickhouse/src/main/scala/org/apache/spark/sql/execution/utils/CHExecUtil.scala
Outdated
Show resolved
Hide resolved
…tion for CompressionCodecFactory
Run Gluten Clickhouse CI |
...e/velox/src/main/java/org/apache/spark/shuffle/writer/VeloxUniffleColumnarShuffleWriter.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@zhouyuan, PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
CC @marin-ma |
@marin-ma, PTAL. |
…tion for CompressionCodecFactory (apache#6725) * [GLUTEN-6724][CH] Shuffle writer supports compression level configuration for CompressionCodecFactory * [GLUTEN-6724][CH] Shuffle writer supports compression level configuration for CompressionCodecFactory
What changes were proposed in this pull request?
ShuffleWriter
andPartitionWriter
do not support compression level configuration in Clickhouse. Meanwhile,CompressionCodecFactory
supports setting compression level. Therefore, shuffle writer supports compression level configuration forCompressionCodecFactory
in Clickhouse backend.(Fixes: #6724)
How was this patch tested?
CI.