Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Use the scripts dir in the current path as SCRIPTDIR #6729

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

liujiayi771
Copy link
Contributor

What changes were proposed in this pull request?

The user may customize VELOX_HOME, or they may use the default directory ep/build-velox/build/velox_ep. However, in the current setup-centos7.sh and setup-centos8.sh, only the default VELOX_HOME path will be used.

In fact, before calling setup-centos7.sh or setup-centos8.sh, builddeps-veloxbe.sh has already changed the directory to VELOX_HOME, so we can directly use the scripts dir in the current path.

How was this patch tested?

N/A

@github-actions github-actions bot added the VELOX label Aug 6, 2024
Copy link

github-actions bot commented Aug 6, 2024

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@liujiayi771
Copy link
Contributor Author

@PHILO-HE Could you help to review?

@liujiayi771 liujiayi771 requested a review from PHILO-HE August 7, 2024 00:25
Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your fix!

@PHILO-HE PHILO-HE merged commit b2a6fd0 into apache:main Aug 7, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants