Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Add shuffle writer type to ColumnarExchange display string #6799

Merged
merged 4 commits into from
Aug 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,10 @@ class CHSparkPlanExecApi extends SparkPlanExecApi {
}
// scalastyle:on argcount

/** Determine whether to use sort-based shuffle based on shuffle partitioning and output. */
override def useSortBasedShuffle(partitioning: Partitioning, output: Seq[Attribute]): Boolean =
false

/**
* Generate ColumnarShuffleWriter for ColumnarShuffleManager.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -548,6 +548,17 @@ class VeloxSparkPlanExecApi extends SparkPlanExecApi {
}
// scalastyle:on argcount

/** Determine whether to use sort-based shuffle based on shuffle partitioning and output. */
override def useSortBasedShuffle(partitioning: Partitioning, output: Seq[Attribute]): Boolean = {
val conf = GlutenConfig.getConf
lazy val isCelebornSortBasedShuffle = conf.isUseCelebornShuffleManager &&
conf.celebornShuffleWriterType == GlutenConfig.GLUTEN_SORT_SHUFFLE_WRITER
partitioning != SinglePartition &&
(partitioning.numPartitions >= GlutenConfig.getConf.columnarShuffleSortPartitionsThreshold ||
output.size >= GlutenConfig.getConf.columnarShuffleSortColumnsThreshold) ||
isCelebornSortBasedShuffle
}

/**
* Generate ColumnarShuffleWriter for ColumnarShuffleManager.
*
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading