Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Update vcpkg glog cmake option to remove glog change from modify_velox.patch #6800

Closed
wants to merge 1 commit into from

Conversation

jinchengchenghh
Copy link
Contributor

@jinchengchenghh jinchengchenghh commented Aug 13, 2024

The shared gluten build does not need glog change in modify_velox.patch because it build glog with component shared, but vcpkg builds without shared before, we could change vcpkg build cmake option to remove it in modify_velox.patch to avoid rebase conflict

@github-actions github-actions bot added the VELOX label Aug 13, 2024
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@github-actions github-actions bot added the BUILD label Aug 13, 2024
@FelixYBW
Copy link
Contributor

Can you add some background info? Does any Velox features enable us to remove this?

@github-actions github-actions bot added the INFRA label Aug 14, 2024
@jinchengchenghh jinchengchenghh changed the title [VL] Remove glog from modify_velox.patch [VL] Update vcpkg glog cmake option to remove glog change from modify_velox.patch Aug 14, 2024
@PHILO-HE
Copy link
Contributor

@jinchengchenghh, please do a rebase.

@jinchengchenghh
Copy link
Contributor Author

vcpkg expects link static glog, so we cannot relax to use glog shared library.

@jinchengchenghh
Copy link
Contributor Author

gluten-it TPCH/DS core dump

It's highly recommended that you fix the library with 'execstack -c <libfile>', or link it with '-z noexecstack'.
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x00007feb7dc2c806, pid=6380, tid=0x00007fec30fff700
#
# JRE version: OpenJDK Runtime Environment (8.0_422-b05) (build 1.8.0_422-8u422-b05-1~20.04-b05)
# Java VM: OpenJDK 64-Bit Server VM (25.422-b05 mixed mode linux-amd64 compressed oops)
# Problematic frame:
# C  [libvelox.so+0x50df806]  google::LogMessage::Init(char const*, int, int, void (google::LogMessage::*)())+0x3f6
#
# Core dump written. Default location: /__w/incubator-gluten/incubator-gluten/tools/gluten-it/core or core.6380
#
# An error report file with more information is saved as:
# /__w/incubator-gluten/incubator-gluten/tools/gluten-it/hs_err_pid6380.log
#
# If you would like to submit a bug report, please visit:
#   http://bugreport.java.com/bugreport/crash.jsp
#
sbin/gluten-it.sh: line 50:  6380 Aborted                 (core dumped) $JAVA_HOME/bin/java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants