-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL] Add a docker build job and reuse pre-built arrow libs #6826
Changes from 9 commits
1289369
0e11ebc
24db594
b099023
ffd33fb
27f9ed6
b383244
3ba2feb
9de4b10
ec31730
08ebc1b
47bf4e6
824f54f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one or more | ||
# contributor license agreements. See the NOTICE file distributed with | ||
# this work for additional information regarding copyright ownership. | ||
# The ASF licenses this file to You under the Apache License, Version 2.0 | ||
# (the "License"); you may not use this file except in compliance with | ||
# the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
name: Build and Push Docker Image | ||
|
||
on: | ||
pull_request: | ||
paths: | ||
- '.github/workflows/docker_image.yml' | ||
schedule: | ||
- cron: '0 20 * * 0' | ||
|
||
jobs: | ||
build: | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- name: Checkout repository | ||
uses: actions/checkout@v2 | ||
|
||
- name: Set up Docker Buildx | ||
uses: docker/setup-buildx-action@v1 | ||
|
||
- name: Login to Docker Hub | ||
uses: docker/login-action@v2 | ||
with: | ||
username: ${{ secrets.DOCKERHUB_USER }} | ||
password: ${{ secrets.DOCKERHUB_TOKEN }} | ||
|
||
- name: Build and push Docker image | ||
uses: docker/build-push-action@v2 | ||
with: | ||
context: . | ||
file: dev/vcpkg/docker/gha-centos-7.dockerfile | ||
push: true | ||
tags: apache/gluten:vcpkg-centos-7 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -51,7 +51,7 @@ concurrency: | |
jobs: | ||
build-native-lib-centos-7: | ||
runs-on: ubuntu-20.04 | ||
container: apache/gluten:gluten-vcpkg-builder_2024_08_05 # centos7 with dependencies installed | ||
container: apache/gluten:vcpkg-centos-7 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are we planning to do the same on centos 8 build? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @zhztheplayer, yes, it would be better to also do this for centos-8 build. At least, those libs generated by arrow build (cpp/java) can be cached in docker to accelerate CI job when the current folder based cache miss happens. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we reuse the binary on centos 7? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @zhouyuan, I will try this. |
||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Generate cache key | ||
|
@@ -63,7 +63,6 @@ jobs: | |
with: | ||
path: | | ||
./cpp/build/releases/ | ||
/root/.m2/repository/org/apache/arrow/ | ||
key: cache-velox-build-centos-7-${{ hashFiles('./cache-key') }} | ||
- name: Build Gluten native libraries | ||
if: ${{ steps.cache.outputs.cache-hit != 'true' }} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,12 +2,9 @@ | |
|
||
set -e | ||
|
||
yum install sudo patch java-1.8.0-openjdk-devel -y | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Initially this is kept in case someone is using this script from a clean centos 7 image There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @zhouyuan, maybe we can just tell user to refer weekly build job for building from clean image. centos-7/8/9, ubuntu-20.04/22.04 are covered in that job. I will document this guide. Thanks! |
||
cd $GITHUB_WORKSPACE/ep/build-velox/src | ||
./get_velox.sh | ||
source /opt/rh/devtoolset-9/enable | ||
cd $GITHUB_WORKSPACE/ | ||
source ./dev/vcpkg/env.sh | ||
sed -i '/^headers/d' ep/build-velox/build/velox_ep/CMakeLists.txt | ||
export NUM_THREADS=4 | ||
./dev/builddeps-veloxbe.sh --build_tests=OFF --build_benchmarks=OFF --enable_s3=ON --enable_gcs=ON --enable_hdfs=ON --enable_abfs=ON | ||
./dev/builddeps-veloxbe.sh --build_tests=OFF --build_benchmarks=OFF --build_arrow=OFF --enable_s3=ON \ | ||
--enable_gcs=ON --enable_hdfs=ON --enable_abfs=ON |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please help to add one doc on how to use this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhouyuan, I will do that. Thanks!