-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-6834][CORE] Remove unused DDL plan that doesn't correspond to Substrait spec #6833
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
Run Gluten Clickhouse CI |
It's worth noting that DDL operations are connected differently in Substrait so that this code would need to be updated before it could be used anyway. |
Hi @rui-mo, where did the code come from, do you remember? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 if the code is unused
By the way I still doubt we can unfork Substrait with minimal effort, though it sounds good. Different native accelerators / libraries would have different ways to implement the same logical computation. It's may not be easy to have a single protocol to unify them at physical level. |
What changes were proposed in this pull request?
This is part of a larger effort to unfork Substrait.
How was this patch tested?
Tested utilizing the available unit tests.